8 replies to this topic

[Kyung]

i know there's the reload buff but that calls even when jhin has more than 0 bullets and is reloading because of not having used an AA/spell in the past 10 seconds (this reload you can cancel with an auto attack).

 

in L$ we had ObjectManager.Player.CanAttack which would be false when Jhin was reloading because he had to.

[Kyung]

Hey just an update. I was able to hack this together to make it work:

local lastattack = 0

Callback.Add('ProcessSpellComplete',
    function(unit, spell)
         if unit.isMe and spell.name:lower():find('attack') 
            and spell.target ~= nil and spell.target.team ~= myHero.team then
            lastattack = GetGameTimer()
        end
    end)

function isreloading()
    local time = GetGameTimer()
    
    for i = 0, myHero.buffCount do
        if GetBuffName(myHero, i) == 'JhinPassiveReload' then
            if GetBuffExpireTime(myHero, i) > GetGameTimer() then
                return (GetBuffStartTime(myHero, i) - lastattack) <= 2.5
            end
        end
    end
    
    return false
end

[Deftsu]

if GotBuff(myHero, "JhinPassiveReload") > 0 then

[Kyung]

if GotBuff(myHero, "JhinPassiveReload") > 0 then

The point of this is that there are two situations in which Jhin reloads his weapon:

1. When he runs out of bullets, in which he has to reload his weapon.
2. When he has not used a spell or an ability in the past 10 seconds, in which he doesn't not have to reload his weapon.

In scenario #2, you can actually cancel the reloading of the weapon and do not need to wait for it to finish.

If you code it in your way, it can have some very frustrating results in some games (e.g. you flash in to 4th shot someone but it's actually passively reloading so you don't auto attack after your flash).

[Deftsu]

The point of this is that there are two situations in which Jhin reloads his weapon:

• When he runs out of bullets, in which he has to reload his weapon.
• When he has not used a spell or an ability in the past 10 seconds, in which he doesn't not have to reload his weapon.

In scenario #2, you can actually cancel the reloading of the weapon and do not need to wait for it to finish.
If you code it in your way, it can have some very frustrating results in some games (e.g. you flash in to 4th shot someone but it's actually passively reloading so you don't auto attack after your flash).

i see, i could just check for LastAttackTime (if it doesn't exceed 10 seconds) in my CanAttack function.

[Kyung]

i see, i could just check for LastAttackTime (if it doesn't exceed 10 seconds) in my CanAttack function.

Ah I didn't know of LastAttackTime but my code basically works similarly. 

[Deftsu]

Ah I didn't know of LastAttackTime but my code basically works similarly.

that's just a var from my orbwalker, there is no such API on GoS.

[Nevachana]

I didnt look into gos api much yet, however, i think that eb and l$ had it.

something to check packets, so if(packet.id == jhin.reload.id) then, jhin will be reloading.

Basically, if you get reloading packet then you can make your boolean or w.e true.

Best way would be adding such check to an even i guess.

Edit: gotbuff should do the job, add that function to a timer and in case is cancelled you can always update your variable, it would be  much better if u posted your idea tho

Edited by Nevachana, 07 February 2017 - 09:21 .

[InsidiousQuack]

just use OnAnimation for when the reload starts.